linux-kernel - Re: [RFC/RFT PATCH v3] sched: automated per tty task groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Nov 2010 19:04:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Galbraith <efault@....de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Markus Trippelsdorf <markus@...ppelsdorf.de>
Subject: Re: [RFC/RFT PATCH v3] sched: automated per tty task groups


* Mike Galbraith <efault@....de> wrote:

> I _finally_ got back to this yesterday, and implemented your suggestion, though 
> with a couple minor variations.  Putting the autogroup pointer in the signal 
> struct didn't look right to me, so I plugged it into the task struct instead.  I 
> also didn't refcount taskgroups, wanted the patchlet to be as self-contained as 
> possible, so refcounted the autogroup struct instead.  I also left group movement 
> on tty disassociation in place, but may nuke it.
> 
> The below has withstood an all night thrashing in my laptop with a PREEMPT_RT 
> kernel, and looks kinda presentable to me, so...

The patch and the diffstat gives me warm fuzzy feelings:

> ---
>  Documentation/kernel-parameters.txt |    2 
>  drivers/char/tty_io.c               |    4 
>  include/linux/sched.h               |   20 ++++
>  init/Kconfig                        |   12 ++
>  kernel/exit.c                       |    1 
>  kernel/sched.c                      |   28 ++++--
>  kernel/sched_autogroup.c            |  161 ++++++++++++++++++++++++++++++++++++
>  kernel/sched_autogroup.h            |   10 ++
>  kernel/sysctl.c                     |   11 ++
>  9 files changed, 241 insertions(+), 8 deletions(-)

Very well contained, minimally invasive to anything else!

( Noticed only one very small detail: sched_autogroup.h has an illness of lack of 
  newlines which makes it a bit hard to read - but this is cured easily. )

I'll test and apply this patch to the scheduler tree, so if anyone has objections 
please holler now :-)

Linus, does this look OK to you too, can i add your Acked-by?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/