linux-kernel - Re: [PATCH] Staging: comedi: fix coding style issue in pcmuio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Nov 2010 01:24:07 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Damian Varayud <davarayud@...il.com>
Cc:	gregkh@...e.de, arun.thomas@...il.com, ezemed7@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix coding style issue in pcmuio.c

On Thu, Nov 11, 2010 at 11:28:12AM -0300, Damian Varayud wrote:
> This is a patch to the pcmuio.c file that fixes up braces, overlines
> and printk warnings found by the checkpatch.pl tool
> 
> Signed-off-by: Ezequiel Medina <ezemed7@...il.com>
> ---

Looks basically Ok, but there are some few problems with the comments.

>  #define REG_INT_PENDING 0x6
> -#define REG_PAGELOCK 0x7	/* page selector register, upper 2 bits select a page
> -				   and bits 0-5 are used to 'lock down' a particular
> -				   port above to make it readonly.  */
> +#define REG_PAGELOCK 0x7/* page selector register, upper 2 bits select a page
> +			   and bits 0-5 are used to 'lock down' a particular
> +			   port above to make it readonly.  */

The original spacing was better.

>  	struct {
> -		int asic;	/* if non-negative, this subdev has an interrupt asic */
> +		int asic;	/* if non-negative, this subdev has an
> +				 * interrupt asic */
>  		int first_chan;	/* if nonnegative, the first channel id for
>  				   interrupts. */

Frankly I would just leave these as is since it's barely over the 80
char mark.  But if you really want to change them then linux multi-line
commenting style is described in Documentation/CodingStyle

The preferred style for long (multi-line) comments is:

        /*
         * This is the preferred style for multi-line
         * comments in the Linux kernel source code.
         * Please use it consistently.
         *
         * Description:  A column of asterisks on the left side,
         * with beginning and ending almost-blank lines.
         */

Please redo the comments and resend.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/