linux-kernel - [PATCH 06/17] staging/vme/tsi148: remove double freeing of the IRQ in .remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101112111440.11631.90734.stgit@ES-BJ21R4J>
Date:	Fri, 12 Nov 2010 11:14:40 +0000
From:	Martyn Welch <martyn.welch@...com>
To:	Greg KH <greg@...ah.com>
Cc:	devel@...verdev.osuosl.org,
	Juan David Gonzalez Cobas <david.cobas@...il.com>,
	"Emilio G. Cota" <cota@...ap.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: [PATCH 06/17] staging/vme/tsi148: remove double freeing of the IRQ in
	.remove

From: Emilio G. Cota <cota@...ap.org>

tsi148_irq_exit is called twice in .remove, which causes an oops.

Remove the second call, which apart from being redundant cannot
possibly work; the CR/CSR space has been already unmapped.

Signed-off-by: Emilio G. Cota <cota@...ap.org>
Acked-by: Martyn Welch <martyn.welch@...com>
---

 drivers/staging/vme/bridges/vme_tsi148.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
index 5c25cd8..2f8f399 100644
--- a/drivers/staging/vme/bridges/vme_tsi148.c
+++ b/drivers/staging/vme/bridges/vme_tsi148.c
@@ -2611,8 +2611,6 @@ static void tsi148_remove(struct pci_dev *pdev)
 		kfree(master_image);
 	}
 
-	tsi148_irq_exit(bridge, pdev);
-
 	iounmap(bridge->base);
 
 	pci_release_regions(pdev);


--
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square, Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/