linux-kernel - RE: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E0D41E29EB0DAC4E9F3FF173962E9E9402DC24F069@dbde02.ent.ti.com>
Date:	Fri, 12 Nov 2010 18:57:02 +0530
From:	"G, Manjunath Kondaiah" <manjugk@...com>
To:	Andrei Emeltchenko <andrei.emeltchenko.news@...il.com>
CC:	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm@...ts.arm.linux.org.uk" <linux-arm@...ts.arm.linux.org.uk>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: RE: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates

 

> -----Original Message-----
> From: Andrei Emeltchenko [mailto:andrei.emeltchenko.news@...il.com] 
> Sent: Friday, November 12, 2010 6:50 PM
> To: G, Manjunath Kondaiah
> Cc: linux-omap@...r.kernel.org; linux-kernel@...r.kernel.org; 
> linux-arm@...ts.arm.linux.org.uk; linux-serial@...r.kernel.org
> Subject: Re: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates
> 
> On Fri, Nov 12, 2010 at 3:17 PM, G, Manjunath Kondaiah 
> <manjugk@...com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: linux-omap-owner@...r.kernel.org
> >> [mailto:linux-omap-owner@...r.kernel.org] On Behalf Of
> >> Emeltchenko Andrei
> >> Sent: Friday, November 12, 2010 6:34 PM
> >> To: linux-omap@...r.kernel.org; linux-kernel@...r.kernel.org;
> >> linux-arm@...ts.arm.linux.org.uk; linux-serial@...r.kernel.org
> >> Subject: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates
> >
> > s/diplicates/duplicates
> >
> >>
> >> From: Andrei Emeltchenko <andrei.emeltchenko@...ia.com>
> >>
> >> Add MDR1 Serial register definition to serial_reg and remove
> >> duplicated
> >> code, remove magic MDR1 register numbers from serial drivers.
> >>
> >> *v2 add OMAP keyword to MDR1 definition
> >> *v3 remove magic from serial drivers
> >> *v4 taking comments from Manjunath and Govindraj: typos, CC
> >>
> >> Andrei Emeltchenko (4):
> >>   OMAP: Serial: Define OMAP uart MDR1 register definitions
> >>   OMAP1: Serial: remove magic numbers for MDR1 reg
> >>   OMAP2: Serial: remove magic numbers for MDR1 reg
> >>   OMAP: Serial: remove redefined MDR1 register definitions
> >>
> >>  arch/arm/mach-omap1/serial.c                  |    6 ++++--
> >>  arch/arm/mach-omap2/serial.c                  |   15 
> +++++++++------
> >>  arch/arm/plat-omap/include/plat/omap-serial.h |    3 ---
> >>  drivers/serial/omap-serial.c                  |    6 +++---
> >>  include/linux/serial_reg.h                    |   12 ++++++++++++
> >>  5 files changed, 28 insertions(+), 14 deletions(-)
> >
> > Do you think patch series is required for these changes? How about
> > merging with single patch?
> 
> I can merge, sometimes somebody need patches to be split, 

why? can you give example?

Please read: http://lwn.net/Articles/139918/
"if you make a single change to numerous files, group those changes into 
a single patch.  Thus a single logical change is contained within a 
single patch."

-Manjunath--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/