linux-kernel - Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k4kiqofx.fsf@deeprootsystems.com>
Date:	Fri, 12 Nov 2010 12:25:38 -0800
From:	Kevin Hilman <khilman@...prootsystems.com>
To:	Andrei Emeltchenko <andrei.emeltchenko.news@...il.com>
Cc:	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions

Andrei Emeltchenko <andrei.emeltchenko.news@...il.com> writes:

> Hi,
>
> On Thu, Nov 11, 2010 at 6:02 PM, Kevin Hilman
> <khilman@...prootsystems.com> wrote:
>> Emeltchenko Andrei <Andrei.Emeltchenko.news@...il.com> writes:
>>
>>> From: Andrei Emeltchenko <andrei.emeltchenko@...ia.com>
>>>
>>> Define MDR1 register serial definitions used in serial and
>>> bluetooth drivers. Remove magic numbers there.
>>
>> Remove magic numbers where?  This patch doesn't remove anything.
>
> We have code which is not yet upstream, it will come through Bluetooth
> subtree at some point, I am also going to remove magic in
> omapX/serial.c drivers in the next patches.
>
> Do you think I need to add those patches?

Not necessarly, but the comment should be a little more clear.
Something "subsequent patches will remove...."

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/