linux-kernel - Re: [PATCH v4] msm: smd: Reduce driver log chatter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1289535774.6519.54.camel@Joe-Laptop>
Date:	Thu, 11 Nov 2010 20:22:54 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Brown <davidb@...eaurora.org>
Cc:	linux-arm-msm@...r.kernel.org,
	Daniel Walker <dwalker@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Brian Swetland <swetland@...gle.com>,
	Arve Hjønnevåg <arve@...roid.com>
Subject: Re: [PATCH v4] msm: smd: Reduce driver log chatter

On Thu, 2010-11-11 at 14:54 -0800, David Brown wrote:
> The MSM smd driver logs numerous messages during startup that are
> useful for debug purposes.  Change some of these to pr_debug() to
> match their purpose, and remove others that aren't really useful.

Hi David.

>  arch/arm/mach-msm/smd.c |   17 +++++++----------
> @@ -725,7 +727,7 @@ int smd_close(smd_channel_t *ch)
>  {
>  	unsigned long flags;
>  
> -	pr_info("smd_close(%p)\n", ch);
> +	pr_debug("smd_close(%p)\n", ch);

Why keep a printk for close without a printk for open?
I suggest removing this one too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/