linux-kernel - Re: [GIT PULL] SCSI queuecommand API change for 2.6.37-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101113042821.GE18258@parisc-linux.org>
Date:	Fri, 12 Nov 2010 21:28:22 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Jeff Garzik <jeff@...zik.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] SCSI queuecommand API change for 2.6.37-rc1

On Fri, Nov 12, 2010 at 05:42:06PM -0800, Linus Torvalds wrote:
> And the sad thing is that this could _trivially_ have been fixed while
> actually making the patch no bigger. Make the new function look like
> 
>    int func(struct Scsi_Host *shost, struct scsi_cmnd *cmd, void
> (*done)(struct scsi_cmnd *));

Actually, it'd be even better if we took away an argument.

int queuecommand(struct scsi_cmnd *cmd);

Every single driver sets cmd->scsi_done = done;

(some don't do it immediately, but they all do it eventually.  Do it in
the single caller, and eventually remove the assignments from the drivers).

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/