linux-kernel - Re: [PATCH] eeepc-wmi: fix compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin-K9jWjtM5qGPP_ZQXFJSAQFCQd9sG939nV033@mail.gmail.com>
Date:	Sun, 14 Nov 2010 17:36:39 +0100
From:	Corentin Chary <corentin.chary@...il.com>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	Chris Bagwell <chris@...bagwell.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeepc-wmi: fix compiler warning

On Wed, Nov 3, 2010 at 7:43 PM, Chris Bagwell <chris@...bagwell.com> wrote:
> On Wed, Nov 3, 2010 at 1:14 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
>> This fixes the following:
>>
>>  CC [M]  drivers/platform/x86/eeepc-wmi.o
>> drivers/platform/x86/eeepc-wmi.c:322: warning: initialization from incompatible pointer type
>>
>> Signed-off-by: Dmitry Torokhov <dtor@...l.ru>
>> ---
>>
>>  drivers/platform/x86/eeepc-wmi.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>>
>> diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
>> index 462ceab..0d50fbb 100644
>> --- a/drivers/platform/x86/eeepc-wmi.c
>> +++ b/drivers/platform/x86/eeepc-wmi.c
>> @@ -298,8 +298,8 @@ static void eeepc_wmi_notify(u32 value, void *context)
>>        kfree(obj);
>>  }
>>
>> -static int store_cpufv(struct device *dev, struct device_attribute *attr,
>> -                      const char *buf, size_t count)
>> +static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
>> +                          const char *buf, size_t count)
>>  {
>>        int value;
>>        struct acpi_buffer input = { (acpi_size)sizeof(value), &value };
>> --
>
> Opps.  Sorry, I missed that warning.  ssize_t is obviously correct return value.
>
> Reviewed-by: Chris Bagwell <chris@...bagwell.com>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Just queued the same patch on my repo, I should have read the list first.

Matthew can you queue this one for next batch ?
Thanks,

-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/