linux-kernel - Re: [PATCH][RESEND] nommu: yield CPU periodically while disposing large VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1289831351.2524.15.camel@iscandar.digidescorp.com>
Date:	Mon, 15 Nov 2010 08:29:11 -0600
From:	"Steven J. Magnani" <steve@...idescorp.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Greg Ungerer <gerg@...pgear.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Subject: Re: [PATCH][RESEND] nommu: yield CPU periodically while disposing
 large VM

On Thu, 2010-11-11 at 18:40 -0800, Andrew Morton wrote:
> On Thu, 11 Nov 2010 14:33:16 -0600 "Steven J. Magnani" <steve@...idescorp.com> wrote:
> 
> > --- a/mm/nommu.c	2010-10-21 07:42:23.000000000 -0500
> > +++ b/mm/nommu.c	2010-10-21 07:46:50.000000000 -0500
> > @@ -1656,6 +1656,7 @@ SYSCALL_DEFINE2(munmap, unsigned long, a
> >  void exit_mmap(struct mm_struct *mm)
> >  {
> >  	struct vm_area_struct *vma;
> > +	unsigned long next_yield = jiffies + HZ;
> >  
> >  	if (!mm)
> >  		return;
> > @@ -1668,6 +1669,11 @@ void exit_mmap(struct mm_struct *mm)
> >  		mm->mmap = vma->vm_next;
> >  		delete_vma_from_mm(vma);
> >  		delete_vma(mm, vma);
> > +		/* Yield periodically to prevent watchdog timeout */
> > +		if (time_after(jiffies, next_yield)) {
> > +			cond_resched();
> > +			next_yield = jiffies + HZ;
> > +		}
> >  	}
> >  
> >  	kleave("");
> 
[snip]
> cond_resched() is pretty efficient and one second is still
> a very long time.  I suspect you don't need the ratelimiting at all?

Probably not, but the issue was that disposal of "large" VMs can starve
the system. Since these are not the norm (otherwise this would have been
fixed long ago) I was attempting to limit the impact on more
"normal"-sized VMs. Responsiveness is not great with a one-second
ratelimit, and as KOSAKI Motohiro points out this fix won't work on
systems with short watchdog intervals. I assumed that these were not
common.

As efficient as schedule() may be, it still scares me to call it on
reclaim of every block of memory allocated by a terminating process,
particularly on the relatively slow processors that inhabit NOMMU land.
It wasn't obvious to me that it has a quick exit. But since we are
talking about sharing the CPU with other processes perhaps this is only
an issue in an OOM scenario, when fast reclaim might be more important.

I can certainly respin the patch to call cond_resched() unconditionally
if that's the consensus.

Regards,
------------------------------------------------------------------------
 Steven J. Magnani               "I claim this network for MARS!
 www.digidescorp.com              Earthling, return my space modulator!"

 #include <standard.disclaimer>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/