linux-kernel - Re: [PATCH] blk-throttle: Fix calculation of max number of WRITES to be dispatched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101115152802.GG30792@redhat.com>
Date:	Mon, 15 Nov 2010 10:28:02 -0500
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Jens Axboe <jaxboe@...ionio.com>,
	linux kernel mailing list <linux-kernel@...r.kernel.org>
Cc:	yummylln@...oo.com.cn
Subject: Re: [PATCH] blk-throttle: Fix calculation of max number of WRITES to
 be dispatched

On Wed, Oct 27, 2010 at 01:29:41PM -0400, Vivek Goyal wrote:
> o Currently we try to dispatch more READS and less WRITES (75%, 25%) in one
>   dispatch round. ummy pointed out that there is a bug in max_nr_writes
>   calculation. This patch fixes it.
> 
> Reported-by: ummy y <yummylln@...oo.com.cn>
> Signed-off-by: Vivek Goyal <vgoyal@...hat.com>
> ---

Hi Jens,

Do you have any concerns about this patch? If not, can you please apply
it.

Thanks
Vivek

>  block/blk-throttle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/block/blk-throttle.c
> ===================================================================
> --- linux-2.6.orig/block/blk-throttle.c	2010-10-27 10:57:25.000000000 -0400
> +++ linux-2.6/block/blk-throttle.c	2010-10-27 11:02:33.733048194 -0400
> @@ -645,7 +645,7 @@ static int throtl_dispatch_tg(struct thr
>  {
>  	unsigned int nr_reads = 0, nr_writes = 0;
>  	unsigned int max_nr_reads = throtl_grp_quantum*3/4;
> -	unsigned int max_nr_writes = throtl_grp_quantum - nr_reads;
> +	unsigned int max_nr_writes = throtl_grp_quantum - max_nr_reads;
>  	struct bio *bio;
>  
>  	/* Try to dispatch 75% READS and 25% WRITES */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/