linux-kernel - Re: [PATCH] cleanup kswapd()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101115092712.BEF4.A69D9226@jp.fujitsu.com>
Date:	Mon, 15 Nov 2010 09:27:32 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	kosaki.motohiro@...fujitsu.com, Mel Gorman <mel@....ul.ie>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] cleanup kswapd()

> On Sun, 14 Nov 2010, KOSAKI Motohiro wrote:
> 
> > 
> > Currently, kswapd() function has deeper nest and it slightly harder to
> > read. cleanup it.
> > 
> > Cc: Mel Gorman <mel@....ul.ie>
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> > ---
> >  mm/vmscan.c |   71 +++++++++++++++++++++++++++++++---------------------------
> >  1 files changed, 38 insertions(+), 33 deletions(-)
> > 
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index 8cc90d5..82ffe5f 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -2364,6 +2364,42 @@ out:
> >  	return sc.nr_reclaimed;
> >  }
> >  
> > +void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
> 
> Shouldn't this be
> 
>   static void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
> 
> ??

Right. thank you.
I'll respin.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/