linux-kernel - Re: [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4CE2434A02000078000226C7@vpn.id2.novell.com>
Date:	Tue, 16 Nov 2010 07:39:38 +0000
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<mingo@...e.hu>, <heukelum@...tmail.fm>,
	"Tetsuo Handa" <penguin-kernel@...ove.SAKURA.ne.jp>,
	<hpa@...ux.intel.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one
	 pushl_cfi argument

>>> On 16.11.10 at 05:45, Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> wrote:
> From ed935c12f0b2b09c1586d22925261378e0d7eb83 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Date: Tue, 16 Nov 2010 13:33:07 +0900
> Subject: [PATCH] x86, asm: Add parentheses around one pushl_cfi argument
> 
> Commit df5d1874 "x86: Use {push,pop}{l,q}_cfi in more places" caused GNU
> assembler 2.15 (Debian Sarge) to fail. It is still failing as of commit
> 07bd8516 "x86, asm: Restore parentheses around one pushl_cfi argument".
> This patch solves build failure with GNU assembler 2.15.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

Acked-by: Jan Beulich <jbeulich@...ell.com>

> ---
>  arch/x86/kernel/entry_32.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> index 59e175e..591e601 100644
> --- a/arch/x86/kernel/entry_32.S
> +++ b/arch/x86/kernel/entry_32.S
> @@ -395,7 +395,7 @@ sysenter_past_esp:
>  	 * A tiny bit of offset fixup is necessary - 4*4 means the 4 words
>  	 * pushed above; +8 corresponds to copy_thread's esp0 setting.
>  	 */
> -	pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
> +	pushl_cfi ((TI_sysenter_return)-THREAD_SIZE_asm+8+4*4)(%esp)
>  	CFI_REL_OFFSET eip, 0
>  
>  	pushl_cfi %eax




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/