linux-kernel - Re: suspicious code in linux/arch/arm/common/sa1111.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Nov 2010 17:09:59 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Pavel Machek <pma@...go.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: suspicious code in linux/arch/arm/common/sa1111.c

On Tue, Nov 16, 2010 at 5:07 PM, Pavel Machek <pma@...go.com> wrote:
> Hi!
>
> Is this good idea?
>
> Signed-off-by: Pavel Machek <pma@...go.com>

Yep, obviously was a typo.

>
> diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
> --- linux.ofic//arch/arm/common/sa1111.c        2010-10-17 20:31:13.000000000 +0200
> +++ linux/arch/arm/common/sa1111.c      2010-11-05 10:44:17.000000000 +0100
> @@ -282,7 +312,7 @@
>        for (i = 0; i < 8; i++) {
>                sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
>                sa1111_writel(ip0, mapbase + SA1111_INTPOL0);
> -               if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
> +               if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
>                        break;
>        }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/