[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTi=dFXu=tGRRJt0cKbm8r528Sk9mHoLZ-Lh+oQ6y@mail.gmail.com>
Date: Tue, 16 Nov 2010 10:07:41 +0000
From: Catalin Marinas <catalin.marinas@....com>
To: Russell King - ARM Linux <linux@....linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE
On 15 November 2010 18:30, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Fri, Nov 12, 2010 at 06:00:25PM +0000, Catalin Marinas wrote:
>> --- a/arch/arm/include/asm/pgtable-2level.h
>> +++ b/arch/arm/include/asm/pgtable-2level.h
>> @@ -128,6 +128,8 @@
>> #define L_PTE_USER (1 << 8)
>> #define L_PTE_EXEC (1 << 9)
>> #define L_PTE_SHARED (1 << 10) /* shared(v6), coherent(xsc3) */
>> +#define L_PTE_NOEXEC (0)
>> +#define L_PTE_NOWRITE (0)
>
> Let's not make this more complicated than it has to be. If we need the
> inverse of WRITE and EXEC, then that's what we should change everyone to,
> not invent a new system to work along side the old system.
Yes, that's fine.
For PMD, we may still need a dummy PMD_SECT_AP_WRITE for the 3-level
definitions unless we change the __pmd() accessor or __pmd_populate().
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists