linux-kernel - 5ada28bf76752 causes compilation error if !CONFIG_LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Nov 2010 15:20:27 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Johannes Berg <johannes.berg@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS

Hi Johannes,
it seems that your patch (5ada28bf76752e33dce3d807bf0dfbe6d1b943ad)
causes the following compilatation error:
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `led_trigger_set':
drivers/leds/led-triggers.c:116: undefined reference to `led_brightness_set'
make[1]: *** [.tmp_vmlinux1] Error 1

AFAICS, led_brightness_set is defined in drivers/leds/led-class.c which
is compiled only if CONFIG_LEDS_CLASS is configured which is not my case
(after make oldconfig with all default values from 37-rc1).

I am not sure what is the right solution whether CONFIG_LEDS_TRIGGERS
should depend on CONFIG_LEDS_CLASS or the patch should be reverted.

My config is attached, if somebody need it.

Thanks
-- 
Michal Hocko
L3 team 
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

View attachment ".config" of type "text/plain" (67649 bytes)