linux-kernel - Re: [PATCH] capabilities/syslog: open code cap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Nov 2010 07:54:18 -0800
From:	Kees Cook <kees.cook@...onical.com>
To:	Eric Paris <eparis@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	torvalds@...ux-foundation.org, joe@...ches.com,
	drosenberg@...curity.com, mingo@...e.hu, eugeneteo@...nel.org,
	akpm@...ux-foundation.org, jmorris@...ei.org, morgan@...nel.org,
	casey@...aufler-ca.com, serge@...lyn.com
Subject: Re: [PATCH] capabilities/syslog: open code cap_syslog logic to fix
 build failure

On Mon, Nov 15, 2010 at 06:36:29PM -0500, Eric Paris wrote:
> The addition of CONFIG_SECURITY_DMESG_RESTRICT resulted in a build failure
> when CONFIG_PRINTK=n.  This is because the capabilities code which used the
> new option was built even though the variable in question didn't exist.  The
> patch here fixes this by moving the capabilities checks out of the LSM and
> into the caller.  All (known) LSMs should have been calling the capabilities
> hook already so it actually makes the code organization better to eliminate
> the hook altogether.
> 
> Signed-off-by: Eric Paris <eparis@...hat.com>
> Acked-by: James Morris <jmorris@...ei.org>

Acked-by: Kees Cook <kees.cook@...onical.com>

-- 
Kees Cook
Ubuntu Security Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/