linux-kernel - Re: [PATCH 6/6] ce4100: Add support for CE4100 EHCI IP block to EHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Nov 2010 15:24:49 -0800
From:	Dirk Brandewie <dirk.brandewie@...il.com>
To:	Greg KH <greg@...ah.com>
CC:	Sergei Shtylyov <sshtylyov@...sta.com>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [PATCH 6/6] ce4100: Add support for CE4100 EHCI IP block to EHCI
 driver

On 11/16/2010 01:46 PM, Greg KH wrote:
> On Wed, Nov 10, 2010 at 01:51:17PM +0300, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 10-11-2010 5:36, Alan Stern wrote:
>>
>>>> In a previous patch in this series GregKH asked that the PCI ID not be added
>>>> to pci_ids.h for ID's that are only used by a single file.
>>>> Here is an updated version of the EHCI controller patch.
>>
>>>> Subject: [PATCH] ce4100: Add support for CE4100 EHCI IP block to EHCI driver
>>
>>>> This patch adds support for the EHCI IP block present on the Intel
>>>> CE4100.
>>
>>>> Signed-off-by: Dirk Brandewie<dirk.brandewie@...il.com>
>>>> CC: linux-usb@...r.kernel.org
>>>> CC: David Brownell<dbrownell@...rs.sourceforge.net>
>>>> ---
>>>>   drivers/usb/host/ehci-pci.c |    4 ++++
>>>>   1 files changed, 4 insertions(+), 0 deletions(-)
>>
>>>> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
>>>> index a1e8d27..da2b196 100644
>>>> --- a/drivers/usb/host/ehci-pci.c
>>>> +++ b/drivers/usb/host/ehci-pci.c
>>>> @@ -124,6 +124,10 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
>>>>   			ehci_info(ehci, "disable lpm for langwell/penwell\n");
>>>>   			ehci->has_lpm = 0;
>>>>   		}
>>>> +		if (pdev->device == 0x2e70) {
>>>> +			hcd->has_tt = 1;
>>>> +			tdi_reset(ehci);
>>>> +		}
>>
>>> I think Greg meant that it's okay to use a symbolic constant for the
>>> PCI ID (it helps tell people what hardware is being handled).  Just
>>> don't add that constant to the pci_ids.h file.
>>
>>     Or at least you need a comment naming the hardware that this ID belongs to.
>
> I agree, something a bit better than just the device id might be nice
> here.
>
> Dirk, care to redo this one and your serial one, with that idea?
>
Yes, sorry for slow turn around been pulled in other random directions the last 
few days

--Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/