linux-kernel - Re: [PATCH v2 1/2] msm: gpio: Add v2 gpio support to MSM SoCs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101116053214.GB15652@jasper.tkos.co.il>
Date:	Tue, 16 Nov 2010 07:32:14 +0200
From:	Baruch Siach <baruch@...s.co.il>
To:	Gregory Bean <gbean@...eaurora.org>
Cc:	dwalker@...eaurora.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] msm: gpio: Add v2 gpio support to MSM SoCs.

Hi Gregory,

On Mon, Nov 15, 2010 at 12:20:18PM -0800, Gregory Bean wrote:
> Beginning with the MSM8x60, the hardware block responsible for gpio
> support changes.  Provide gpiolib support for the new v2 architecture.
> 
> Cc: Baruch Siach <baruch@...s.co.il>
> Signed-off-by: Gregory Bean <gbean@...eaurora.org>
> ---

[snip]

> +struct msm_gpio_dev {
> +	struct gpio_chip gpio_chip;
> +};

This wrapper struct seems redundant. You only use it in msm_gpio_probe, where 
you can just use 'struct gpio_chip' directly.

> +static DEFINE_SPINLOCK(tlmm_lock);
> +
> +static inline struct msm_gpio_dev *to_msm_gpio_dev(struct gpio_chip *chip)
> +{
> +	return container_of(chip, struct msm_gpio_dev, gpio_chip);
> +}

Not used.

> +static inline void set_gpio_bits(unsigned n, void __iomem *reg)
> +{
> +	writel(readl(reg) | n, reg);
> +}

Move the locking in, or better, eliminate it, since it's only used in 
msm_gpio_direction_output.

[snip]

> +static struct platform_device msm_device_gpio = {
> +	.name = "msmgpio",
> +	.id   = 0,

Redundant.

> +};

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/