linux-kernel - Re: [PATCH, v2] x86-64: fix and clean up AMD Fam10 MMCONF enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4CE397BF0200007800022AD6@vpn.id2.novell.com>
Date:	Wed, 17 Nov 2010 07:52:15 +0000
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Yinghai Lu" <yinghai@...nel.org>
Cc:	<mingo@...e.hu>, <tglx@...utronix.de>,
	<linux-kernel@...r.kernel.org>, <hpa@...or.com>
Subject: Re: [PATCH, v2] x86-64: fix and clean up AMD Fam10 MMCONF
	 enabling

>>> On 16.11.10 at 23:26, Yinghai Lu <yinghai@...nel.org> wrote:
> On 11/16/2010 12:25 AM, Jan Beulich wrote:
>> @@ -206,8 +200,10 @@ void __cpuinit fam10h_check_enable_mmcfg
>>  	 * with 256 buses
>>  	 */
>>  	get_fam10h_pci_mmconf_base();
>> -	if (fam10h_pci_mmconf_base_status <= 0)
>> +	if (!fam10h_pci_mmconf_base) {
>> +		pci_probe &= ~PCI_CHECK_ENABLE_AMD_MMCONF;
> 
> case: if no cpu mmconf reg are set by BIOS and later if BSP can not get new 
> base,
> 
> this pci_probe &= line will be called for every AP...

No, because the function itself has

	if (!(pci_probe & PCI_CHECK_ENABLE_AMD_MMCONF))
		return;

at its very beginning.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/