linux-kernel - Re: [RESEND PATCH] tags: put function prototypes back!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101117090654.GZ8942@pengutronix.de>
Date:	Wed, 17 Nov 2010 10:06:54 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	stefani@...bold.net
Subject: Re: [RESEND PATCH] tags: put function prototypes back!

Hello Marek,

On Thu, Nov 04, 2010 at 10:24:16AM +0100, Uwe Kleine-König wrote:
> Commit 7db86dc (ctags: usability fix) removed function prototypes from
> tags file claiming "It makes no real sense to include function
> prototypes".
> But it is useful for quickly determining which header file developer
> needs to include to fix compilation.
> 
> Now if someone wants to remove forward declatations (which I agree are
> baggage), write a postprocessing script.
While sorting my pending patches I noticed that there's a typo, can you
please do s/declatations/declarations/ when taking the patch.
(Or tell me to resend an updated patch.)  (I'd say the sentence before
needs an "a" before developer, I'm not a native speaker though, so I
kept Alexey's wording.)

Best regards and thanks
Uwe 

> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  scripts/tags.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 8509bb5..e091db3 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -123,7 +123,7 @@ exuberant()
>  	-I ____cacheline_internodealigned_in_smp                \
>  	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
>  	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
> -	--extra=+f --c-kinds=-px                                \
> +	--extra=+f --c-kinds=+px                                \
>  	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
>  	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
>  
> -- 
> 1.7.2.3
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/