[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1290015033.2351.69.camel@e102109-lin.cambridge.arm.com>
Date: Wed, 17 Nov 2010 17:30:33 +0000
From: Catalin Marinas <catalin.marinas@....com>
To: Russell King - ARM Linux <linux@....linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and
L_PTE_NOWRITE
On Wed, 2010-11-17 at 17:24 +0000, Russell King - ARM Linux wrote:
> On Wed, Nov 17, 2010 at 05:22:12PM +0000, Catalin Marinas wrote:
> > Ah, good point, that was the mask.
> >
> > So for dmacoherent we make sure that L_PTE_EXEC is cleared. I suspect
> > we should now make sure that L_PTE_NOEXEC is set. For the other two,
> > just leave them as they are.
>
> Already done:
>
> #define pgprot_dmacoherent(prot) \
> - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_BUFFERABLE)
> + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_BUFFERABLE|L_PTE_XN)
> ...
> #define pgprot_dmacoherent(prot) \
> - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_UNCACHED)
> + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_UNCACHED|L_PTE_XN)
Are you already doing such changes? Just to avoid duplicating effort
(and use common naming scheme).
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists