linux-kernel - Re: BKL: remove extraneous #include <smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Nov 2010 14:05:26 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	torvalds <torvalds@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: BKL: remove extraneous #include <smp_lock.h>

On Wed, 17 Nov 2010 21:59:01 GMT Linux Kernel Mailing List wrote:

> Gitweb:     http://git.kernel.org/linus/451a3c24b0135bce54542009b5fde43846c7cf67
> Commit:     451a3c24b0135bce54542009b5fde43846c7cf67
> Parent:     55f6561c6941713ab5ae9180525b026dd40b7d14
> Author:     Arnd Bergmann <arnd@...db.de>
> AuthorDate: Wed Nov 17 16:26:55 2010 +0100
> Committer:  Linus Torvalds <torvalds@...ux-foundation.org>
> CommitDate: Wed Nov 17 08:59:32 2010 -0800
> 
>     BKL: remove extraneous #include <smp_lock.h>
>     
>     The big kernel lock has been removed from all these files at some point,
>     leaving only the #include.
>     
>     Remove this too as a cleanup.
>     
>     Signed-off-by: Arnd Bergmann <arnd@...db.de>
>     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> ---



causes build errors in linux-next of NOV. 17.

see http://lkml.org/lkml/2010/11/17/339
and http://lkml.org/lkml/2010/11/17/365


smp_lock.h was removed from hardirq.h.  smp_lock.h provided the function prototype
for kernel_locked().  Should source files now #include <linux/smp_lock.h> ?
even when not being built for SMP?


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/