linux-kernel - Re: [PATCH 1/2] drivers: regulator: core: use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290040194.28741.324.camel@Joe-Laptop>
Date:	Wed, 17 Nov 2010 16:29:54 -0800
From:	Joe Perches <joe@...ches.com>
To:	Daniel Walker <dwalker@...eaurora.org>
Cc:	Liam Girdwood <lrg@...mlogic.co.uk>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, bleong@...eaurora.org
Subject: Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt

On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote:
> This adds a pr_fmt line which uses the __func__ macro. I also
> convert the current pr_ lines to remove their __func__ usage.
[]
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> @@ -765,8 +767,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
>  
>  		/* else require explicit machine-level constraints */
>  		if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
> -			pr_err("%s: %s '%s' voltage constraints\n",
> -				       __func__, "invalid", name);
> +			pr_err("%s '%s' voltage constraints\n", "invalid",
> +				name);

Using a separate pointer for invalid and unsupportable
doesn't save much text space and is very hard to grep.

I think it's more intelligible as:

			pr_err("%s: Invalid voltage constraints\n", name);

> -			pr_err("%s: %s '%s' voltage constraints\n",
> -				       __func__, "unsupportable", name);
> +			pr_err("%s '%s' voltage constraints\n", "unsupportable",
> +				name);

and
			pr_err("%s: Unsupportable voltage constraints\n", name);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/