linux-kernel - Re: tty: add 'active' sysfs attribute to tty0 and console device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Nov 2010 12:00:21 +0100
From:	"Dr. Werner Fink" <werner@...e.de>
To:	Greg KH <greg@...ah.com>
Cc:	Lennart Poettering <mzxreary@...inter.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Kay Sievers <kay.sievers@...y.org>, Valdis.Kletnieks@...edu,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: tty: add 'active' sysfs attribute to tty0 and console device

On Wed, Nov 17, 2010 at 05:53:10PM -0800, Greg KH wrote:
> On Thu, Nov 18, 2010 at 02:48:48AM +0100, Lennart Poettering wrote:
> > On Wed, 17.11.10 17:27, Greg KH (greg@...ah.com) wrote:
> > 
> > > I can do any one, or multiple things from the following options:
> > > 
> > > 	- disable the existing ioctl to return an error so that no new
> > > 	  userspace program starts to use it thinking it is valid
> > > 	- accept Werner's patch for those who like proc files
> > > 	- accept Kay's patch
> > > 
> > > Any suggestions?
> > 
> > Maybe this is not so surprising, but I definitely want item #3 from the
> > list. 
> > 
> > I am against #2, since #1 is a much nicer solution, and having both
> > would be needlessly redundant.
> 
> I think you mean s/1/3/ here, right?
> 
> And yes, having both will be redundant, and Werner seems to not be
> responding anymore as to why he feels his patch is somehow still needed
> given that Kay's patch accomplishes the same thing from what I can tell.

I'm still reading and I'm wondering about this discussion.  The only
thing I'd like to be able is to detect all ttys used for the system
console even if not a VT (not having a VT but several other consoles
is the most pressing case e.g. on s390 or zSeries) and this without
forcing (and maybe stealing) the controlling tty on the system console
to be able to detect the primary tty/console.

The primary tty marked with CON_CONSDEV and normally the first in
console_drivers.  This can be done with Kay's patch as well as with
my approach.  And both approaches do have the advantage to become
the full list of consoles which will help me to extend e.g. sulogin ...

The only advantage of my approache in comparision to Kay's one is that
the remaining console flags become visible for normal user space.
This was an idea of Randy Dunlap otherwise my patch would provide
the same information as the patch of Kay.

Maybe Kay could extend his patch in that way that the flags and the
facilities (having device, read, write, and unblank) are also shown
in the new file /sys/class/tty/console/active ... but maybe Randy
could says a few words for what this is usable.

     Werner

-- 
System V style init programs - http://savannah.nongnu.org/projects/sysvinit/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/