lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Nov 2010 11:07:31 +0000 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Jesse Marroquin <jesse.marroquin@...im-ic.com> Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>, Liam Girdwood <lrg@...mlogic.co.uk>, Peter Hsiang <Peter.Hsiang@...im-ic.com>, Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ASoC: Add support for MAX98089 CODEC On Wed, Nov 17, 2010 at 02:26:40PM -0600, Jesse Marroquin wrote: > This patch adds initial support for the MAX98089 CODEC. Applied, thanks. One thing: > struct max98088_priv { > u8 reg_cache[M98088_REG_CNT]; > + enum max98088_type devtype; You currently never actually read the devtype anywhere - if the devices really are fully register compatible (eg, if the differences are in physical or electrical characteristics which aren't visible to software) then there's no need to bother doing this, though equally well it does no harm. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists