[<prev] [next>] [day] [month] [year] [list]
Message-ID: <tip-d5ad140bc1505a98c0f040937125bfcbb508078f@git.kernel.org>
Date: Thu, 18 Nov 2010 14:08:58 GMT
From: tip-bot for Nikhil Rao <ncrao@...gle.com>
To: linux-tip-commits@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
a.p.zijlstra@...llo.nl, ncrao@...gle.com, alex.shi@...el.com,
tglx@...utronix.de, mingo@...e.hu
Subject: [tip:sched/urgent] sched: Fix idle balancing
Commit-ID: d5ad140bc1505a98c0f040937125bfcbb508078f
Gitweb: http://git.kernel.org/tip/d5ad140bc1505a98c0f040937125bfcbb508078f
Author: Nikhil Rao <ncrao@...gle.com>
AuthorDate: Wed, 17 Nov 2010 11:42:04 -0800
Committer: Ingo Molnar <mingo@...e.hu>
CommitDate: Thu, 18 Nov 2010 13:12:33 +0100
sched: Fix idle balancing
An earlier commit reverts idle balancing throttling reset to fix a 30%
regression in volanomark throughput. We still need to reset idle_stamp
when we pull a task in newidle balance.
Reported-by: Alex Shi <alex.shi@...el.com>
Signed-off-by: Nikhil Rao <ncrao@...gle.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
LKML-Reference: <1290022924-3548-1-git-send-email-ncrao@...gle.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
kernel/sched_fair.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index ba0556d..00ebd76 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -3215,8 +3215,10 @@ static void idle_balance(int this_cpu, struct rq *this_rq)
interval = msecs_to_jiffies(sd->balance_interval);
if (time_after(next_balance, sd->last_balance + interval))
next_balance = sd->last_balance + interval;
- if (pulled_task)
+ if (pulled_task) {
+ this_rq->idle_stamp = 0;
break;
+ }
}
raw_spin_lock(&this_rq->lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists