linux-kernel - [tip:perf/urgent] irq_work: Drop cmpxchg() result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Nov 2010 14:09:33 GMT
From:	tip-bot for Sergio Aguirre <saaguirre@...com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	a.p.zijlstra@...llo.nl, schwidefsky@...ibm.com, kyle@...artin.ca,
	ying.huang@...el.com, saaguirre@...com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:perf/urgent] irq_work: Drop cmpxchg() result

Commit-ID:  94e8ba728640dc01375a14e337f3b892bfacbeeb
Gitweb:     http://git.kernel.org/tip/94e8ba728640dc01375a14e337f3b892bfacbeeb
Author:     Sergio Aguirre <saaguirre@...com>
AuthorDate: Tue, 16 Nov 2010 12:02:47 -0600
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Thu, 18 Nov 2010 13:18:47 +0100

irq_work: Drop cmpxchg() result

The compiler warned us about:

 kernel/irq_work.c: In function 'irq_work_run':
 kernel/irq_work.c:148: warning: value computed is not used

Dropping the cmpxchg() result is indeed weird, but correct -
so annotate away the warning.

Signed-off-by: Sergio Aguirre <saaguirre@...com>
Cc: Huang Ying <ying.huang@...el.com>
Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
Cc: Kyle McMartin <kyle@...artin.ca>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
LKML-Reference: <1289930567-17828-1-git-send-email-saaguirre@...com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 kernel/irq_work.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index f16763f..90f8819 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -145,7 +145,9 @@ void irq_work_run(void)
 		 * Clear the BUSY bit and return to the free state if
 		 * no-one else claimed it meanwhile.
 		 */
-		cmpxchg(&entry->next, next_flags(NULL, IRQ_WORK_BUSY), NULL);
+		(void)cmpxchg(&entry->next,
+			      next_flags(NULL, IRQ_WORK_BUSY),
+			      NULL);
 	}
 }
 EXPORT_SYMBOL_GPL(irq_work_run);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/