lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CE53871.6080004@metafoo.de>
Date:	Thu, 18 Nov 2010 15:30:09 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Anton Vorontsov <cbouatmailru@...il.com>
CC:	rklein@...dia.com, broonie@...nsource.wolfsonmicro.com,
	achew@...dia.com, olof@...om.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] POWER: Add gpio charger driver

Anton Vorontsov wrote:
> On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:
>> This patch adds a simple driver for chargers indicating their online status
>> through a GPIO pin.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
>>
>> ---
>> Changes since v1
>> * Fix typo in Kconfig
>> * Fix whitespace issues
>> * Add missing includes in the header file
>> * Make the irq field of the driver struct unsigned and assume that 0 is not a
>>   valid irq.
> 
> Applied, thanks!
> 
> But please, look at Mark Brown comments. If they are still
> applicable, the follow up patch would be great.
> 
> Thanks!
> 

Hi

I'll send a follow up patch later today. I think I had one or two other issues on my
list that need to be addressed.
I wanted to wait with v3 until it was clear whether the driver had a chance to be
merged at all.
Do you prefer a v3 of the original patch or an incremental one?

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ