linux-kernel - Re: Question about nfs_page_async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290094063.3187.41.camel@heimdal.trondhjem.org>
Date:	Thu, 18 Nov 2010 10:27:43 -0500
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Peng Tao <lkml.bergwolf@...il.com>
Cc:	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Question about nfs_page_async_flush assertion

On Thu, 2010-11-18 at 18:53 +0800, Peng Tao wrote:
> Hi, all,
> 
> nfs_writepages calls into
> write_cache_pages()->nfs_writepages_callback()->nfs_do_writepage()->nfs_page_async_flush(),
> where it asserts BUG_ON(test_bit(PG_CLEAN, &req->wb_flags)).
> My question is: how do we guarantee the request has PG_CLEAN flag set?

We don't. We guarantee that the request has PG_CLEAN cleared, and that
is done when we dirty the page (see nfs_try_to_update_request()).

Cheers
  Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/