linux-kernel - Re: [PATCH v6] usb: Adding SuperSpeed support to dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Nov 2010 07:55:58 -0800
From:	Greg KH <gregkh@...e.de>
To:	Tatyana Brokhman <tlinder@...eaurora.org>
Cc:	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd

On Thu, Nov 18, 2010 at 02:57:32PM +0200, Tatyana Brokhman wrote:
> USB 3.0 hub includes 2 hubs - HS and SS ones.
> Thus, when dummy_hcd enabled it will register 2 root hubs (SS and HS).
> 
> Signed-off-by: Tatyana Brokhman <tlinder@...eaurora.org>

{sigh}

This changelog entry makes absolutely no sense.  Please write something
that describes what you are doing, and why you are doing it, with full
details (i.e. links to the tests you ran, etc.)  Look at how other
people write their comments for major patches like this, be descriptive
and verbose.  It will help when in 3 years you are asked why this patch
did what it did.

I'm sorry if it feels like I'm picking on you, but I'm trying to help
you get it right for this, and future contributions.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/