linux-kernel - RE: 5ada28bf76752 causes compilation error if !CONFIG_LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C5C86A19469DAE48AAAD0E5F3716E44501D41ECB46@irsmsx504.ger.corp.intel.com>
Date:	Thu, 18 Nov 2010 16:52:59 +0000
From:	"Berg, Johannes" <johannes.berg@...el.com>
To:	Michal Hocko <mhocko@...e.cz>
CC:	LKML <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: RE: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS

> > > it seems that your patch (5ada28bf76752e33dce3d807bf0dfbe6d1b943ad)
> > > causes the following compilatation error:
> > >   LD      .tmp_vmlinux1
> > > drivers/built-in.o: In function `led_trigger_set':
> > > drivers/leds/led-triggers.c:116: undefined reference to
> > > `led_brightness_set'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> > >
> > > AFAICS, led_brightness_set is defined in drivers/leds/led-class.c
> which
> > > is compiled only if CONFIG_LEDS_CLASS is configured which is not my
> > > case (after make oldconfig with all default values from 37-rc1).
> > >
> > > I am not sure what is the right solution whether
> CONFIG_LEDS_TRIGGERS
> > > should depend on CONFIG_LEDS_CLASS or the patch should be reverted.
> > >
> > > My config is attached, if somebody need it.
> >
> > Hmm, we did find that, and I made a patch to fix up the Kconfig, that
> apparently hasn't made it in? Bit confused now.
> 
> Does this mean that I should enable CONFIG_LEDS_CLASS to work around
> the issue for this moment?

I think that'd be easiest, yes.

johannes
--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland 
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/