linux-kernel - RE: [PATCH] hid: usbhid: New hid quirks for Panasonic Elite Panaboard T-780 and T-880

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3BF066A8BAB61C43B779966CEE6D7FA018BC9E1C10@e6.universe.dart.spb>
Date:	Thu, 18 Nov 2010 19:59:50 +0300
From:	Anton Chikin <Anton.Chikin@...aart.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	"chatty@...c.fr" <chatty@...c.fr>,
	"spbnick@...il.com" <spbnick@...il.com>,
	"anisse@...ier.eu" <anisse@...ier.eu>,
	"cascardo@...oscopio.com" <cascardo@...oscopio.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Gregory Burmistrov <grig@...aart.com>
Subject: RE: [PATCH] hid: usbhid: New hid quirks for Panasonic Elite
 Panaboard T-780 and T-880

Hello Jiri,

Actually our driver is implemented as the fork of usbhid driver. I'm now trying to move to HID bus. I think I need some help with this. 
I've copied /drivers/hid/hid-cando.c source code, changed device IDs in hid_driver structure, added my device IDs to /drivers/hid/hid-core.c hid_blacklist[] array, but my probe() method still never get called. Could you please help me with this?

My driver code and Makefile are in attachment.

Thank you.

-----Original Message-----
From: Jiri Kosina [mailto:jkosina@...e.cz] 
Sent: Wednesday, November 03, 2010 4:28 PM
To: Anton Chikin
Cc: chatty@...c.fr; spbnick@...il.com; anisse@...ier.eu; cascardo@...oscopio.com; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org; Gregory Burmistrov; Paul Osborn
Subject: RE: [PATCH] hid: usbhid: New hid quirks for Panasonic Elite Panaboard T-780 and T-880

On Tue, 2 Nov 2010, Anton Chikin wrote:

> Thank you for your feedback.
> 
> With the generic hid driver device is working in mouse-mode, turning 
> it into the huge touchscreen, which is completely useless for the end-user.

Still, at least some very basic and limited/crippled functionality is there. So my preferred mode of operation now would be having the device being claimed by generic driver and wait for your proper full-fledged driver.

> On some Linux systems hid driver is loaded from init.rd image, so we 
> can't feed our quirks to it while boot process and we can't rebuild 
> init.rd image on the user's machine because some Linux distributives 
> doesn't have special tools preinstalled.
> 
> We are going to submit our driver to the Linux kernel quickly, so 
> everyone can improve it.

That would be great, I'll be happy to review and merge it. Are you planning to have it as a driver on HID bus, or completely separate USB driver?

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.

View attachment "hid-ubt780.c" of type "text/plain" (7006 bytes)

Download attachment "Makefile" of type "application/octet-stream" (1891 bytes)