linux-kernel - Re: How do I choose an arbitrary minor number for my tty device?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101118022434.GA9833@suse.de>
Date:	Wed, 17 Nov 2010 18:24:34 -0800
From:	Greg KH <gregkh@...e.de>
To:	Timur Tabi <timur@...escale.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Scott Wood <scottwood@...escale.com>,
	Stuart Yoder <stuart.yoder@...escale.com>
Subject: Re: How do I choose an arbitrary minor number for my tty device?

On Wed, Nov 17, 2010 at 04:42:22PM -0600, Timur Tabi wrote:
> Greg KH wrote:
> > I think you are forgetting that your byte channel devices must be
> > "devices" in the system here, right?  There is a 'struct bus_id" for
> > your bus that these devices live on.
> 
> Do you mean "struct bus_type"?  I don't have any concept of a "bus" in my
> driver.  I didn't know I needed to create one, and I'm not sure how, either.

You need to create one as you really have a "bus" here, as you
described.

> I guess my real problem is that I'm not really sure what I should be doing.  I
> already have a plain character driver that creates devices for each byte
> channel.  First I call alloc_chrdev_region() to get a started dev_id.  Then I
> iterate over the byte channels and call device_create() for each one, with NULL
> for the parent.  At the end, I call cdev_init() and cdev_add().

Ick, no.

Please take a step back and go to your original message where you
described something like "we have a bus and devices we discover on the
bus and they have ids".  Because of that, you should just create a bus,
create the devices on the bus, and then, attach specific types of
drivers to those devices (like your tty driver.)

And your bus is automatically discoverable, right?  So you don't need
any interface for userspace to "create" devices, so you should be fine.

If it's not discoverable, go kick some firmware programmers butt and
make it so, as that is unforgivable in this age.  Seriously, that's flat
out broken and wrong, get it fixed first.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/