linux-kernel - Re: [PATCH v3 2/2] msm: gpio: Add irq support to v2 gpiolib.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1011181115220.9788@gbean-linux.qualcomm.com>
Date:	Thu, 18 Nov 2010 11:20:28 -0800 (PST)
From:	Gregory Bean <gbean@...eaurora.org>
To:	Pavan Kondeti <pkondeti@...eaurora.org>
cc:	Gregory Bean <gbean@...eaurora.org>, dwalker@...eaurora.org,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] msm: gpio: Add irq support to v2 gpiolib.

>> +	spin_lock_irqsave(&tlmm_lock, irq_flags);
>> +	for_each_set_bit(i, msm_gpio.enabled_irqs, NR_GPIO_IRQS) {
>> +		if (!test_bit(i, msm_gpio.wake_irqs))
>> +			writel(TARGET_PROC_NONE, GPIO_INTR_CFG_SU(i));
>> +	}
> If none of the enabled irqs is configured as a wakeup source, should not we
> disable the summary IRQ?

I do not believe there is a need.  If no irqs are wakeup sources, then
the summary irq is also not a wakeup source, see msm_gpio_irq_set_wake().
And if the GIC will mask the TLMM block appropriately during system PM
without further bit-twiddling from me, why complicate my PM hooks further?

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/