| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1290112054983@xenotime.net> Date: Thu, 18 Nov 2010 12:27:34 -0800 From: Randy Dunlap <rdunlap@...otime.net> To: linux-kernel@...r.kernel.org Cc: Joel Becker <joel.becker@...cle.com> Subject: [PATCH 2/7] Documentation: make configfs example code simpler, clearer From: Dan Carpenter <error27@...il.com> If "p" is NULL then it will cause an oops when we pass it to simple_strtoul(). In this case "p" can not be NULL so I removed the check. I also changed the check a little to make it more explicit that we are testing whether p points to the NUL char. Signed-off-by: Dan Carpenter <error27@...il.com> Acked-by: Joel Becker <joel.becker@...cle.com> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com> --- V2: Added some parenthesis to make the precedence more clear. --- Documentation/filesystems/configfs/configfs_example_explicit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.37-rc2-git4.orig/Documentation/filesystems/configfs/configfs_example_explicit.c +++ linux-2.6.37-rc2-git4/Documentation/filesystems/configfs/configfs_example_explicit.c @@ -89,7 +89,7 @@ static ssize_t childless_storeme_write(s char *p = (char *) page; tmp = simple_strtoul(p, &p, 10); - if (!p || (*p && (*p != '\n'))) + if ((*p != '\0') && (*p != '\n')) return -EINVAL; if (tmp > INT_MAX) -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists