linux-kernel - Re: [PATCH 1/4] x86: platform: mrst: check platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101118201808.06731611@linux.intel.com>
Date:	Thu, 18 Nov 2010 20:18:08 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Vasiliy Kulikov <segoon@...nwall.com>
Cc:	kernel-janitors@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Feng Tang <feng.tang@...el.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] x86: platform: mrst: check
 platform_device_register() return code

On Thu, 18 Nov 2010 21:44:21 +0300
Vasiliy Kulikov <segoon@...nwall.com> wrote:

> On Thu, Nov 18, 2010 at 18:18 +0000, Alan Cox wrote:
> > >  I cannot compile this driver in next-20101117, so it is not
> > > tested at all.
> > 
> > Compile or test - if it bombs out compiling for you please send me
> > (off list the .config that fails so I can fix that
> > 
> > Otherwise NAK the patch because it needs to do the cleanup but
> > thanks for finding the bug - you've done the hard 99%
> 
> make -C /home/vasya/linux arch/x86/platform/mrst/vrtc.o
> make: Entering directory `/home/vasya/dev/linux-next'
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CC      arch/x86/platform/mrst/vrtc.o
> arch/x86/platform/mrst/vrtc.c: In function 'mrst_rtc_init':
> arch/x86/platform/mrst/vrtc.c:113: error: 'FIX_LNW_VRTC' undeclared
> (first use in this function) arch/x86/platform/mrst/vrtc.c:113:
> error: (Each undeclared identifier is reported only once
> arch/x86/platform/mrst/vrtc.c:113: error: for each function it
> appears in.) make[1]: *** [arch/x86/platform/mrst/vrtc.o] Error 1
> 
> Both with allyesconfig and allmodconfig, x86_64.

I can't duplicate this.

It's defined if CONFIG_X86_MRST is defined, and the file in question is
only compiled if CONFIG_X86_MRST is defined



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/