[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20101118.125717.52197531.davem@davemloft.net>
Date: Thu, 18 Nov 2010 12:57:17 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: grant.likely@...retlab.ca
Cc: ddaney@...iumnetworks.com, devicetree-discuss@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices.
From: Grant Likely <grant.likely@...retlab.ca>
Date: Thu, 18 Nov 2010 13:44:10 -0700
> On Thu, Nov 18, 2010 at 11:46:16AM -0800, David Miller wrote:
>> From: David Daney <ddaney@...iumnetworks.com>
>> Date: Wed, 17 Nov 2010 15:54:31 -0800
>>
>> > The 88E1149R is 10/100/1000 quad-gigabit Ethernet PHY. The
>> > .config_aneg function can be shared with 88E1118, but it needs its own
>> > .config_init.
>> >
>> > Signed-off-by: David Daney <ddaney@...iumnetworks.com>
>>
>> Please resend this when you've respun patch #1 based upon the feedback
>> you've been given.
>
> It looks to me that this patch has no dependencies on the first patch.
> ddaney; what say you?
It absolutely does, it references a function create by patch #1
In fact it's the whole _entire_ point of patch #1, to allow
patch #2 to be possible. Did you even check?
Otherwise I would waste his time asking for a respin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists