linux-kernel - Re: [PATCH][resend][SCSI] Reduce number of sequential pointer derefs in scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1011182158270.11697@swampdragon.chaosbits.net>
Date:	Thu, 18 Nov 2010 21:59:07 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Russell King <rmk@....linux.org.uk>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi@...r.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	linux-kernel@...r.kernel.org, Eric Youngdale <eric@...ante.org>,
	"David S. Miller" <davem@...emloft.net>,
	Mike Anderson <andmike@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH][resend][SCSI] Reduce number of sequential pointer derefs
 in scsi_error.c and reduce size as well

On Thu, 18 Nov 2010, Russell King wrote:

> On Thu, Nov 18, 2010 at 09:49:29PM +0100, Jesper Juhl wrote:
> > @@ -617,10 +623,10 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
> >  
> >  static int __scsi_try_to_abort_cmd(struct scsi_cmnd *scmd)
> >  {
> > -	if (!scmd->device->host->hostt->eh_abort_handler)
> > -		return FAILED;
> > -
> > -	return scmd->device->host->hostt->eh_abort_handler(scmd);
> > +    struct scsi_host_template *hostt = scmd->device->host->hostt;
> > +    if (!hostt->eh_abort_handler)
> > +        return FAILED;
> > +    return hostt->eh_abort_handler(scmd);
> 
> Not that I have much to do with SCSI anymore... I spotted the above.
> Is there any particular reason for using spaces to indent here rather
> than our usual tabs?
> 
No. That was me and Emacs having a slight disagreement (see the mail I 
just sent)...

-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/