linux-kernel - Re: ocfs2: char is not always signed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101118234343.GK19821@mail.oracle.com>
Date:	Thu, 18 Nov 2010 15:43:43 -0800
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Milton Miller <miltonm@....com>
Cc:	Tao Ma <tao.ma@...cle.com>, ocfs2-devel@....oracle.com,
	Mark Fasheh <mfasheh@...e.com>, linux-kernel@...r.kernel.org,
	Goldwyn Rodrigues <rgoldwyn@...e.de>
Subject: Re: ocfs2: char is not always signed

On Wed, Nov 17, 2010 at 10:20:11PM -0600, Milton Miller wrote:
> Commit 1c66b360fe262 (Change some lock status member in ocfs2_lock_res
> to char.)  states that these fields need to be signed due to comparision
> to -1, but only changed the type from unsigned char to char.   However, it
> is a compiler option if char is a signed or unsigned type.  Change these
> fields to signed char so the code will work with all compilers.
> 
> Signed-off-by: Milton Miller <miltonm@....com>

	This patch is now in the fixes branch of ocfs2.git.

Joel

-- 

"This is the end, beautiful friend.
 This is the end, my only friend the end
 Of our elaborate plans, the end
 Of everything that stands, the end
 No safety or surprise, the end
 I'll never look into your eyes again."

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/