linux-kernel - Re: [PATCH] fs: call security_d_instantiate in d_obtain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CE60AE9.2070101@countercultured.net>
Date:	Fri, 19 Nov 2010 00:28:09 -0500
From:	David Quigley <merlin@...ntercultured.net>
To:	Eric Paris <eparis@...hat.com>
CC:	"J. Bruce Fields" <bfields@...ldses.org>,
	Josef Bacik <josef@...hat.com>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, sds@...ho.nsa.gov,
	selinux@...ho.nsa.gov, linux-security-module@...r.kernel.org
Subject: Re: [PATCH] fs: call security_d_instantiate in d_obtain_alias

[snip]
> If you have persistent xattr support we need the dentry since the xattr
> code requires a dentry.  I have no idea why but that's what
> inode->i_op->getxattr() requires.
>

The original reason that the xattr operations take dentries is because 
of p9fs and CIFS. CIFS uses the name of the file to grab the extended 
attributes and so does p9fs. I had tried to remove this a while ago but 
couldn't find a way around that. When trying to find a solution I also 
got push back from Miklos (FUSE) as he views a filesystem being able to 
make xattr decisions based on the path name being a valid use-case.

Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/