linux-kernel - Re: [PATCH net-next-2.6 v3] can: Topcliff: PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <007401cb87b1$a773b3d0$66f8800a@maildom.okisemi.com>
Date:	Fri, 19 Nov 2010 15:18:58 +0900
From:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
To:	"Marc Kleine-Budde" <mkl@...gutronix.de>
Cc:	"Wolfgang Grandegger" <wg@...ndegger.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Wolfram Sang" <w.sang@...gutronix.de>,
	"Christian Pellegrin" <chripell@...e.org>,
	"Barry Song" <21cnbao@...il.com>,
	"Samuel Ortiz" <sameo@...ux.intel.com>,
	<socketcan-core@...ts.berlios.de>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <andrew.chih.howe.khor@...el.com>,
	<qi.wang@...el.com>, <margie.foster@...el.com>,
	<yong.y.wang@...el.com>,
	"Masayuki Ohtake" <masa-korg@....okisemi.com>,
	<kok.howg.ewe@...el.com>, <joel.clark@...el.com>
Subject: Re: [PATCH net-next-2.6 v3] can: Topcliff: PCH_CAN driver: Add Flow control,

On Tuesday, November 16, 2010 9:22 PM, Marc Kleine-Budde wrote :

Except the following, I have updated/resubmitted already .

>>  static int pch_can_rx_poll(struct napi_struct *napi, int quota)
>>  {
>>   struct net_device *ndev = napi->dev;
>>   struct pch_can_priv *priv = netdev_priv(ndev);
>> - struct net_device_stats *stats = &(priv->ndev->stats);
>> - u32 dlc;
>>   u32 int_stat;
>>   int rcv_pkts = 0;
                    ^^^^
>can be removed...if you remove the += below
Since there is "goto" code, "=0" is better.



>> - spin_unlock_irqrestore(&priv->msgif_reg_lock, flags);
>> + pch_can_rw_msg_obj(&priv->regs->ifregs[1].creq, tx_obj_no);
>Still we have the busy waiting in the TX path. Maybe you can move the
>waiting before accessing the if[1] and remove the busy waiting here.
I can't understand your saying.
For transmitting data, calling pch_can_rw_msg_obj is mandatory.


---
Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/