linux-kernel - Re: [PATCH -next] staging: fix winbond build, needs delay.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Nov 2010 09:54:43 -0800
From:	Greg KH <gregkh@...e.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Pavel Machek <pavel@....cz>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] staging: fix winbond build, needs delay.h

On Fri, Nov 19, 2010 at 09:48:44AM -0800, Randy Dunlap wrote:
> On 11/19/10 09:38, Greg KH wrote:
> > On Fri, Nov 19, 2010 at 09:30:18AM -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@...cle.com>
> >>
> >> winbond drivers use msleep() and delay(), so include linux/delay.h
> >> in a common header file to prevent build errors.
> >>
> >> drivers/staging/winbond/phy_calibration.c:987: error: implicit declaration of function 'msleep'
> >> drivers/staging/winbond/phy_calibration.c:1556: error: implicit declaration of function 'udelay'
> >> drivers/staging/winbond/reg.c:894: error: implicit declaration of function 'msleep'
> >> drivers/staging/winbond/reg.c:1178: error: implicit declaration of function 'udelay'
> > 
> > Is this error showing up in Linus's tree, or only in linux-next?
> 
> I saw it in linux-next, but it looks like it should also be a build error
> in mainline.

Ok, thanks, I'll queue it up for Linus's tree then.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/