linux-kernel - Re: [patch 13/28] fs: dcache scale d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTingh9UxuD6xtoXmErf2v8gMr96ir5CVQhB=YdQ0@mail.gmail.com>
Date:	Fri, 19 Nov 2010 11:41:04 -0800
From:	Tim Pepper <lnxninja@...ux.vnet.ibm.com>
To:	Nick Piggin <npiggin@...nel.dk>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 13/28] fs: dcache scale d_unhashed

On Tue, Nov 16, 2010 at 6:09 AM, Nick Piggin <npiggin@...nel.dk> wrote:

> @@ -1797,7 +1822,10 @@ static void d_move_locked(struct dentry
>        /*
>         * XXXX: do we really need to take target->d_lock?
>         */
> -       if (target < dentry) {
> +       if (d_ancestor(dentry, target)) {
> +               spin_lock(&dentry->d_lock);
> +               spin_lock_nested(&target->d_lock, DENTRY_D_LOCK_NESTED);
> +       } else if (d_ancestor(target, dentry) || target < dentry) {
>                spin_lock(&target->d_lock);
>                spin_lock_nested(&dentry->d_lock, DENTRY_D_LOCK_NESTED);
>        } else {

This is the first hunk out of the series where I feel like reading the
new code makes me say "ugh".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/