linux-kernel - Re: [patch 15/28] fs: scale inode alias list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimpZ4910=Cz-A0CO0GUqF8c16Z+XKbTg0jzLpm=@mail.gmail.com>
Date:	Fri, 19 Nov 2010 11:41:50 -0800
From:	Tim Pepper <lnxninja@...ux.vnet.ibm.com>
To:	Nick Piggin <npiggin@...nel.dk>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 15/28] fs: scale inode alias list

On Tue, Nov 16, 2010 at 6:09 AM, Nick Piggin <npiggin@...nel.dk> wrote:

> @@ -290,13 +300,18 @@ void dput(struct dentry *dentry)
>                         * want to reduce dcache_lock anyway so this will
>                         * get improved.
>                         */
> +drop1:
>                        spin_unlock(&dentry->d_lock);
>                        goto repeat;
>                }
> -               if (parent && !spin_trylock(&parent->d_lock)) {
> -                       spin_unlock(&dentry->d_lock);
> +               if (!spin_trylock(&dcache_inode_lock)) {
> +drop2:
>                        spin_unlock(&dcache_lock);
> -                       goto repeat;
> +                       goto drop1;
> +               }
> +               if (parent && !spin_trylock(&parent->d_lock)) {
> +                       spin_unlock(&dcache_inode_lock);
> +                       goto drop2;
>                }
>        }
>        dentry->d_count--;

Another ugh moment.  But it gets better in patches 18 and 20.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/