linux-kernel - Re: [PATCH] USB: g_serial: Allow to override the default VID/PID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101120001247.GB17421@kroah.com>
Date:	Fri, 19 Nov 2010 16:12:47 -0800
From:	Greg KH <greg@...ah.com>
To:	Jef Driesen <jefdriesen@...enet.be>,
	Robert Lukassen <Robert.Lukassen@...tom.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: g_serial: Allow to override the default VID/PID

On Sat, Nov 20, 2010 at 12:32:34AM +0100, Jef Driesen wrote:
> Override the default VID/PID if custom values are supplied through the
> idVendor and idProduct kernel module parameters.
> 
> Signed-off-by: Jef Driesen <jefdriesen@...enet.be>

So this patch resolves the bug found in
1ab83238740ff1e1773d5c13ecac43c60cf4aec4 which showed up in .35-rc1,
right?

Robert, any objection to this as it was your patch that broke things?

thanks,

greg k-h
> ---
>  drivers/usb/gadget/serial.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/serial.c b/drivers/usb/gadget/serial.c
> index f46a609..77b410e 100644
> --- a/drivers/usb/gadget/serial.c
> +++ b/drivers/usb/gadget/serial.c
> @@ -271,6 +271,11 @@ static int __init init(void)
>  	}
>  	strings_dev[STRING_DESCRIPTION_IDX].s = serial_config_driver.label;
>  
> +	if (idVendor)
> +		device_desc.idVendor = idVendor;
> +	if (idProduct)
> +		device_desc.idProduct = idProduct;
> +
>  	return usb_composite_register(&gserial_driver);
>  }
>  module_init(init);
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/