linux-kernel - Re: [PATCH] checkpatch: teach checkpatch about rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101121083121.GA15587@redhat.com>
Date:	Sun, 21 Nov 2010 10:31:22 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>,
	Patrick Pannuto <ppannuto@...eaurora.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: teach checkpatch about rcu

On Thu, Nov 18, 2010 at 06:15:47PM +0100, Eric Dumazet wrote:
> Le jeudi 18 novembre 2010 à 19:05 +0200, Michael S. Tsirkin a écrit :
> > I got this:
> > +       struct kvm_kernel_irq_routing_entry __rcu *irq_entry;
> > which is because checkpatch does not know about __rcu.
> > So here's a patch to teach it about that tag.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> > ---
> >  scripts/checkpatch.pl |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 2039acd..1b11c8e 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -143,6 +143,7 @@ our $Sparse	= qr{
> >  			__must_check|
> >  			__init_refok|
> >  			__kprobes|
> > +			__rcu|
> >  			__ref
> >  		}x;
> >  
> 
> 
> Hmm, why __percpu is in $Attribute, and __rcu in $Sparse ?
> 

I can't say: we have __kernel and __user and __iomem address spaces in $Sparse
and only __percpu in $Attribute, so I thought address spaces belong in
$Sparse and __percpu just sneaked in there with a ton of other
attributes added by 03f1df7da5696ddfa6e167b37e0c0ce5aad3de79.

Should __percpu be moved to $Sparse perhaps?

-- 
MST

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/