linux-kernel - Re: [RFC PATCH 3/3 v2] perf: Update perf tool to monitor uncore events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1290348733.2245.173.camel@localhost>
Date:	Sun, 21 Nov 2010 22:12:13 +0800
From:	Lin Ming <ming.m.lin@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	Stephane Eranian <eranian@...gle.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [RFC PATCH 3/3 v2] perf: Update perf tool to monitor uncore
 events

On Sun, 2010-11-21 at 20:09 +0800, Andi Kleen wrote:
> >
> >              samples  pcnt function               DSO
> >              _______ _____ ______________________
> > ____________________________________
> >
> >                 8.00 18.6% kallsyms_expand_symbol [kernel.kallsyms]
> 
> Reporting a symbol for an uncore event seems highly misleading.
> After all the uncore counter has no idea for which core the event was,
> so there isn't really any instruction pointer to report.
> The event could be event caused by a PCI device or similar.
> 
> For per function monitoring of uncore events one has to use
> OFFCORE_RESPONSE, like I implemented recently.

Let me look at this and then get back to you.

Thanks.

> 
> I would suggest to not report any symbol names for uncore events.
> Doing so just will confuse users.
> 
> In fact I suspect uncore events are only really useful
> with "stat", but not with "top", or if they are used in top
> then the symbol reporting should be disabled.
> 
> -Andi
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/