linux-kernel - Re: [PATCH 14/14] sound/ppc: Use printf extension %pR for struct resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h62vpsvrf.wl%tiwai@suse.de>
Date:	Mon, 22 Nov 2010 07:44:04 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Jiri Kosina <trivial@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] sound/ppc: Use printf extension %pR for struct resource

At Fri, 12 Nov 2010 13:38:04 -0800,
Joe Perches wrote:
> 
> Using %pR standardizes the struct resource output.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied now.  Thanks.


Takashi


> ---
>  sound/ppc/pmac.c |   12 ++++--------
>  1 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
> index 8508117..b47cfd4 100644
> --- a/sound/ppc/pmac.c
> +++ b/sound/ppc/pmac.c
> @@ -1228,10 +1228,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return)
>  					       chip->rsrc[i].start + 1,
>  					       rnames[i]) == NULL) {
>  				printk(KERN_ERR "snd: can't request rsrc "
> -				       " %d (%s: 0x%016llx:%016llx)\n",
> -				       i, rnames[i],
> -				       (unsigned long long)chip->rsrc[i].start,
> -				       (unsigned long long)chip->rsrc[i].end);
> +				       " %d (%s: %pR)\n",
> +				       i, rnames[i], &chip->rsrc[i]);
>  				err = -ENODEV;
>  				goto __error;
>  			}
> @@ -1256,10 +1254,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return)
>  					       chip->rsrc[i].start + 1,
>  					       rnames[i]) == NULL) {
>  				printk(KERN_ERR "snd: can't request rsrc "
> -				       " %d (%s: 0x%016llx:%016llx)\n",
> -				       i, rnames[i],
> -				       (unsigned long long)chip->rsrc[i].start,
> -				       (unsigned long long)chip->rsrc[i].end);
> +				       " %d (%s: %pR)\n",
> +				       i, rnames[i], &chip->rsrc[i]);
>  				err = -ENODEV;
>  				goto __error;
>  			}
> -- 
> 1.7.3.1.g432b3.dirty
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/