linux-kernel - Re: [PATCH] ALSA: snd-atmel-abdac: test wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5htyj9rgly.wl%tiwai@suse.de>
Date:	Mon, 22 Nov 2010 07:56:41 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Vasiliy Kulikov <segoon@...nwall.com>
Cc:	kernel-janitors@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: snd-atmel-abdac: test wrong variable

At Sun, 21 Nov 2010 20:40:07 +0300,
Vasiliy Kulikov wrote:
> 
> After clk_get() pclk is checked second time instead of sample_clk check.
> 
> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>

Applied now.  Thanks.


Takashi


> ---
>  Compile tested only.
> 
>  sound/atmel/abdac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
> index f2f41c8..4e47baa 100644
> --- a/sound/atmel/abdac.c
> +++ b/sound/atmel/abdac.c
> @@ -420,7 +420,7 @@ static int __devinit atmel_abdac_probe(struct platform_device *pdev)
>  		return PTR_ERR(pclk);
>  	}
>  	sample_clk = clk_get(&pdev->dev, "sample_clk");
> -	if (IS_ERR(pclk)) {
> +	if (IS_ERR(sample_clk)) {
>  		dev_dbg(&pdev->dev, "no sample clock\n");
>  		retval = PTR_ERR(pclk);
>  		goto out_put_pclk;
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/