linux-kernel - Re: [PATCH] viafb: I2C/DDC LCD detection for VIA framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CEA7D13.9070602@bspu.unibel.by>
Date:	Mon, 22 Nov 2010 16:24:19 +0200
From:	Dzianis Kahanovich <mahatma@...u.unibel.by>
To:	Dan Carpenter <error27@...il.com>, mahatma@...by,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] viafb: I2C/DDC LCD detection for VIA framebuffer

Sorry for mistake. I sure to remove "const" but revert to older code later. I
repost fixed patch ("v2") to avoid formal problems. Sorry.

Dan Carpenter wrote:
> On Mon, Nov 22, 2010 at 02:31:55PM +0200, Dzianis Kahanovich wrote:
>> +static void via_i2c_detect(void)
>> +{
>> +	const u8 *edid;
>         ^^^^^
> 
>> +free_edid:
>> +		kfree(edid);
>                 ^^^^^^^^^^^
> 
> That probably shouldn't be const.
> 
>> +		if (n > 1)
>> +			break;
>> +	}
>> +}
>> +
>>
> 
> regards,
> dan carpenter
> 
> 


-- 
WBR, Dzianis Kahanovich AKA Denis Kaganovich, http://mahatma.bspu.unibel.by/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/